search

briandonahue / FluxJpeg.Core

Clone of fjcore library that seems to be stagant on google code
http://code.google.com/p/fjcore/
20 stars 10 forks source link

Signed assemblies with snk-key to make assemblies names strong. #3

Closed vladsm closed 10 years ago

vladsm commented 10 years ago

I have faced the problem by referencing FJCore assembly without strong name in my strong-named assembly. So I suggest to sign assemblies with snk.

briandonahue commented 10 years ago

Hmm. I wonder if we'll get subsequent complaints for users who don't want to deal with strong named assemblies... @cureos, do you have an opinion on this?

cureos commented 10 years ago

I am not an expert on assembly signing, but I think it makes sense to sign FJCore. It is not dependent on any assembly other than core .NET etc., and upstream I do not think there will be a problem if an unsigned assembly tries to reference a signed version of FJCore? Anyone volunteering to publish an updated version on NuGet :-) ?

vladsm commented 10 years ago

@briandonahue, @cureos Sure, there are no problems in referencing strong-named assemblies by unsigned assemblies (just think about core/framework assemblies which are all strong-named).

@cureos If nobody has time to publish new version on NuGet, I can do it. I have published it already on our company local NuGet source. As for nuget.org I still have no account there but I can create it shortly. The only problem here is that someone of owners should add me as owner of the package to make me able to update it. Actually to be honest I'm not an expert in JPEG and not planning to develop code-base later on. So may be it doesn't make sense to add me as package owner.

cureos commented 10 years ago

@vladsm First of all, many thanks for identifying and solving this issue. All work that make the library more useful is very well appreciated. And as you point out, it is probably more convenient if anyone that already has the Github and NuGet privileges for this library makes the necessary updates. If @briandonahue agrees, I can deal with the pull request and make the upload to NuGet. I cannot promise that it will be done immediately though, I have a few other things in the pipeline at the moment too :-)

briandonahue commented 10 years ago

Sure - I was going to try to get to it, too, but have been swamped with work and have family things going on both days this weekend. Thanks!

cureos commented 10 years ago

I have now tagged v0.7.2 here on Github, and I have also uploaded an updated NuGet package. Admittedly a little sloppy ... I have not yet verified that the uploaded package works as intended. Do not hesitate to try it out and notify me if you find any problems before me :-) Again, @vladsm, many thanks for your contribution.