consider inverting chunk names before initial release

briandorsey / wavrw

wavrw is a command line tool to read and write WAV files with a focus on visualizing the structure of files and parsing metadata.

Apache License 2.0

2 stars 1 forks source link

consider inverting chunk names before initial release #91

Closed briandorsey closed 2 months ago

briandorsey commented 3 months ago

Fmt --> FmtSized & FmtData --> Fmt ?

Matches with SizedChunk Trait. Reduces silliness like DataData. More accurate & probably makes more sense if/when constructing new chunks programmatically in the future.

briandorsey commented 3 months ago

Or... back to appending _Chunk. Which would give us FmtChunk for the wrapper, and Fmt or FmtData for the actual data.

Alternatively, think about the verbs for converting between them. Which in this case would be something like .wrap_chunk() or .into_chunk() and .into_model() or .into_inner() or something

briandorsey commented 2 months ago

Decided on using Chunk for the KnownChunk wrappers and removing Data from the inner structs. Now Fmt refers to the logical data and FmtChunk is the KnownChunk wrapper with the ID and size as well.