search

briandowns / spinner

Go (golang) package with 90 configurable terminal spinner/progress indicators.
Apache License 2.0
2.33k stars 129 forks source link

spinner fills console with `WWWW` in JetBrains console. #110

Closed fredliang44 closed 3 years ago

fredliang44 commented 3 years ago

As I started spinner in Goland, spinner fills console with WWWW.

https://user-images.githubusercontent.com/22412638/104083012-df8ad100-5275-11eb-8c44-173e7623e18f.mp4

fredliang44 commented 3 years ago

But if I started command from iTerm, the problem no longer appears.

hardboiledalex commented 3 years ago

Same issue, problem exists for standard Windows terminal since v1.12.0. Rollback to v1.11.1 helps. For macOS iTerm - no problems.

briandowns commented 3 years ago

Hmmm, I wonder what the possible commonality between the Goland terminal and the Windows terminal is? I'll checkout a differ between the two releases to see if I see anything obvious. Thanks for reporting this.

Jaeyo commented 3 years ago

same problem on windows putty terminal. I also rollback to v1.11.1 and resolved.

akshaybabloo commented 3 years ago

Any update on this?

2000Slash commented 3 years ago

Just encountered this on Linux with zsh shell. But only for one line that was longer than my terminal width and had to be wrapped around.

Dreamacro commented 3 years ago

@briandowns Here's the root cause: https://github.com/briandowns/spinner/blob/2cb1a331834ae44d9f509fd8f583b41ff5c2ff85/spinner.go#L399-L401

I tried removing this code and it still works fine on macOS iterm2, Terminal, JetBrains terminal and vscode's terminal. I'm not sure what this compatibility is for, maybe a historical reason?

briandowns commented 3 years ago

Thanks @Dreamacro . Would it be possible to open a pull request?