briandunn / flatware

A parallel test runner for RSpec and Cucumber with pretty output
MIT License
256 stars 35 forks source link

Fix: Use max for duration and load_time in SummaryNotification #83

Closed tomasdundacek closed 4 months ago

tomasdundacek commented 4 months ago

Hey, I just discovered this gem and was playing around with it this weekend and I love it. Found a small issue though with times measured so here's a fix :)

Context

In SummaryNotification, all the values were added. While this is good for example arrays and errors_outside_of_examples_count, for duration and load_time this does not make much sense and times measured were unrealistic.

Solution

I have opted for max value of the two attributes.

Before:

image

After:

image