search

brianegan / dart_redux_epics

Redux.dart middleware for handling actions using Dart Streams
MIT License
141 stars 22 forks source link

Combined epic should be called once during initialization #32

Closed solid-software closed 5 years ago

solid-software commented 5 years ago

Hi @brianegan, thanks for your work on this package!

We noticed that combined epic function called multiple times during initialization which seems to be a bad thing due to performance & might cause some issues if a user doesn't expect it to be called multiple times.

Could you please review this PR and let us know what you think?

brianegan commented 5 years ago

Oh boy, great catch! Great PR with test case :)

brianegan commented 5 years ago

Published as version 0.11.0 -- thanks again!

solid-software commented 5 years ago

☺️thanks - we are happy to contribute