Closed brianegan closed 4 years ago
Thanks for the amazing review, @rrousselGit!
Merging #168 into master will decrease coverage by
1.33%
. The diff coverage is55.52%
.
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
- Coverage 68.81% 67.48% -1.34%
==========================================
Files 166 176 +10
Lines 3723 4084 +361
==========================================
+ Hits 2562 2756 +194
- Misses 1161 1328 +167
Impacted Files | Coverage Δ | |
---|---|---|
mvu/lib/edit/types.dart | 100% <ø> (ø) |
:arrow_up: |
mvu/lib/common/snackbar.dart | 16.66% <ø> (+1.28%) |
:arrow_up: |
change_notifier_provider/lib/edit_todo_screen.dart | 0% <0%> (ø) |
|
change_notifier_provider/lib/details_screen.dart | 0% <0%> (ø) |
|
mvu/lib/edit/types.g.dart | 48.93% <100%> (ø) |
:arrow_up: |
built_redux/lib/models/serializers.g.dart | 100% <100%> (ø) |
:arrow_up: |
...repository_simple/lib/src/reactive_repository.dart | 96.29% <100%> (ø) |
:arrow_up: |
...tifier_provider/lib/home/extra_actions_button.dart | 21.05% <21.05%> (ø) |
|
built_redux/lib/models/app_tab.g.dart | 70% <33.33%> (ø) |
:arrow_up: |
...ange_notifier_provider/lib/home/filter_button.dart | 34.37% <34.37%> (ø) |
|
... and 21 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 01c1330...3230873. Read the comment docs.
I let the last one go for way too long and bits got outdated. I've updated the sample with the latest code and version of provider.
@rrousselGit would greatly appreciate a review from your side! This is largely a translation of the scoped model app into a Provider app.
Fixes #134