search

brianegan / flutter_architecture_samples

TodoMVC for Flutter
http://fluttersamples.com/
BSD 3-Clause "New" or "Revised" License
8.74k stars 1.71k forks source link

states_rebuilder sample #172

Closed GIfatahTH closed 4 years ago

GIfatahTH commented 4 years ago

171 add states_rebuilder sample.

brianegan commented 4 years ago

Hey, thanks so much! Giving it a review now :)

Some things I see right off the bat:

  1. Please add your app and yourself as a contributor to the root README and index.html file (the index file gets deployed to fluttersamples.com as a static site)
  2. Please update the codecov and travis yaml files to include this project in the build matrices :)
  3. Please trim down the README in your project a bit to only include high-level information and small code snippets for demonstration, but please avoid copy/pasting all the code into the readme -- it'll be a bit of a burden to maintain in the long run.
GIfatahTH commented 4 years ago

What do you think of it now? It seems like it is ok, isn't it? How to add the web version?

brianegan commented 4 years ago

Yep, looks great! Unfortunately I need to configure the CI using the web interface to publish the web artifact, and I can't configure it using a yaml file, so I'll go ahead and do that.

One last change: could you please add the "web demo" link to the readme and index.html pointing to http://fas_states_rebuilder.codemagic.app/.

brianegan commented 4 years ago

Actually looks like I might need to merge this into master before I can configure that setup in the UI! I'll go ahead and merge and add those bits in. Thanks again for the contribution :)

brianegan commented 4 years ago

Unfortunately ran into a bug with the CI when it comes to deploying the web version. I've contact the CI company and they're working on a fix! Hopefully publish later this week or next week sometime, but didn't get a clear date.

brianegan commented 4 years ago

Just a heads up -- it looks like the CI issue was resolved and I was able to publish the app :)

http://fas_states_rebuilder.codemagic.app/