Closed GIfatahTH closed 4 years ago
Hey, thanks so much! Giving it a review now :)
Some things I see right off the bat:
What do you think of it now? It seems like it is ok, isn't it? How to add the web version?
Yep, looks great! Unfortunately I need to configure the CI using the web interface to publish the web artifact, and I can't configure it using a yaml file, so I'll go ahead and do that.
One last change: could you please add the "web demo" link to the readme and index.html pointing to http://fas_states_rebuilder.codemagic.app/
.
Actually looks like I might need to merge this into master before I can configure that setup in the UI! I'll go ahead and merge and add those bits in. Thanks again for the contribution :)
Unfortunately ran into a bug with the CI when it comes to deploying the web version. I've contact the CI company and they're working on a fix! Hopefully publish later this week or next week sometime, but didn't get a clear date.
Just a heads up -- it looks like the CI issue was resolved and I was able to publish the app :)
171 add states_rebuilder sample.