search

brianegan / flutter_redux

A library that connects Widgets to a Redux Store
MIT License
1.65k stars 217 forks source link

Error handling converters #170

Closed brianegan closed 4 years ago

brianegan commented 4 years ago

Errors in converters are, at the moment, hard to spot. This PR changes that and makes them extremely explicit! Any time an error occurs in a converter, a ConverterError will be thrown with the underlying error and stacktrace.

On device, it will look like a normal "Big Red Error"

Screenshot_1582119968

In your terminal, it will display the full stacktrace so you can click on the offending line to jump right to it:

Screen Shot 2020-02-19 at 2 46 46 PM
miquelbeltran commented 4 years ago

The change looks good to me!

I tested it on my project (I had an error in a converter so was the perfect time to verify it). I guess this just need to fix the conficts and would be good to go.

codecov[bot] commented 4 years ago

Codecov Report

Merging #170 into master will increase coverage by 0.02%. The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   93.93%   93.96%   +0.02%     
==========================================
  Files           1        1              
  Lines          99      116      +17     
==========================================
+ Hits           93      109      +16     
- Misses          6        7       +1
Impacted Files Coverage Δ
lib/flutter_redux.dart 93.96% <97.14%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c583fa...880c273. Read the comment docs.