search

brianegan / flutter_redux

A library that connects Widgets to a Redux Store
MIT License
1.65k stars 219 forks source link

Remove null check from WidgetsBinding.instance #229

Closed brianegan closed 2 years ago

brianegan commented 2 years ago

Fixes #228

codecov[bot] commented 2 years ago

Codecov Report

Merging #229 (427fa0e) into master (848cf12) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   98.19%   98.24%   +0.04%     
==========================================
  Files           1        1              
  Lines         111      114       +3     
==========================================
+ Hits          109      112       +3     
  Misses          2        2
Impacted Files Coverage Δ
lib/flutter_redux.dart 98.24% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03e7bbd...427fa0e. Read the comment docs.

kjawadDeveloper commented 2 years ago

Will you merge it?

brianegan commented 2 years ago

I will merge it when this change reaches the stable channel (next release). This change is only on beta and master atm.

You can use the prerelease version on pub if you need to support the beta or master channel.

On Tue, Apr 12, 2022 at 9:12 AM khwaja Jawad Ahmed @.***> wrote:

Will you merge it?

— Reply to this email directly, view it on GitHub https://github.com/brianegan/flutter_redux/pull/229#issuecomment-1096221554, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA65DEXUS5GWU5TFAPJJ23VEUO6RANCNFSM5SSXOUTQ . You are receiving this because you authored the thread.Message ID: @.***>