search

brianegan / flutter_redux

A library that connects Widgets to a Redux Store
MIT License
1.65k stars 219 forks source link

fixed nullable error #235

Closed jonaswre closed 2 years ago

jonaswre commented 2 years ago

When compiling I always get the error that instance might be null. adding the questionsmark fixis this.

brianegan commented 2 years ago

Heya @jonaswre -- thanks for the contribution! Unfortunately, I think you might be on an old version of Flutter. As of Flutter 3, WidgetsBinding.instance is no longer nullable, and I had to remove the ? to fix analysis errors related to Flutter 3. In fact, that's what version 0.10.0-beta was all about :)

https://pub.dev/packages/flutter_redux/changelog#0100-beta1

Therefore, the checks have failed on this PR and unfortunately I cannot merge it. Please upgrade to the latest Flutter, or if you really need to support an older version of Flutter you may have to maintain an internal fork of this library, since I can only commit to supporting the stable version of Flutter.

jonaswre commented 2 years ago

Thanks for your info. To be honest when I saw your last commit from a couple of days ago. I felt wierd that something like this would slip through.