brianegan / new_flutter_template

Test ideas for a new flutter template
140 stars 23 forks source link

Should the new template include Custom Theming of the app? #17

Open ibhavikmakwana opened 3 years ago

ibhavikmakwana commented 3 years ago

While building a flutter application implementing a proper theme can be difficult I believe, a developer should not change the only primary color, there are many things that need to be taken care of.

Here is an example that I follow for building the custom theme In my Apps.

In a separate class defining the required themes (let's say Dark/Light modes) and adding the required theme attributes over there and mostly we are going to deal with the colors so we can have them in the separate file + class.

brianegan commented 3 years ago

Thanks for the feedback! We actually have some evaluations that demonstrate how to handle light and dark theme controls :)

https://github.com/brianegan/new_flutter_template/tree/main/evaluations/list_detail_mvc_vn_two_features/lib/src/settings

We weren't sure if it made sense to keep it in the template, but perhaps as an additional Code Lab on top of the template. What do you think would be most helpful?

ibhavikmakwana commented 3 years ago

I am sure we do not want to overengineer the template that leads to the confusion but having a code lab will surely help.