[WIP] First sample app proposal

[brianegan]

We've taken the feedback from the community and we're starting to assemble it into a sample app. Please note, this is a work in progress!

Features

• [x] List/Detail App with 2 Features: Items and Settings
• [x] Localize the title of the app
• [x] Analysis options using pedantic
• [x] MVC with ChangeNotifier
• [x] Only Flutter/Dart Team dependencies
• [x] Objects passed down via constructors, no third-party library
• [x] Feature-first folder structure
• [x] 1 Image asset in 1x, 2x, and 3x
• [x] Dummy Tests that demonstrate Widget, Unit, and Integration Tests
• [x] Logging & Error Reporting Implementation
• [x] Responsive Design

Refinement

Tasks we want to address once we've agreed to the overall features & structure.

• [x] Add high-quality code comments throughout the app that follow Flutter official documentation style
• [x] Clean up pubspec.yaml
• [x] Use Widgets instead of _buildMobileContent style methods
• [x] Rename Widgets for clarity
• [x] Finalize Enabled & Disabled Lint Rules & fix any related errors.
• [x] Enable null safety and fix related errors? (Reviewed notes: No).

[brianegan]

Thanks for taking an early look and giving thoughts on the overall direction!

Definitely some things that are more polished, and other parts are more questionable WIP code in here that needs a clean-up :)

I'll go through all the feedback and make updates on Monday and Tuesday!

[brianegan]

Can we build the functionality in a way that 90% of developers will want to keep it and/or add to it, instead of ripping it out?

On the other hand, I wonder if we really need Item to work. I'd like to see a version of the template where Item/Dummy is only a scaffold, with zero functionality. No plumbing that will need to be ripped out immediately.

This was my gut feeling as well -- the items folder contains lot of code, most of which will be deleted. In my opinion, even handling responsive breakpoints really comes down to the design of the app and it's very hard to put anything general in place.

I'll try a rendition with a much simpler items or dummy folder to see how it goes, keeping in mind the "90%" rule.

[brianegan]

Thanks again for all the feedback! I've published another version of the proposal that is starting to get into a bit more production-ready shape. I'd appreciate any feedback folks have the time to give!

Changes include:

• Remove Logging. Different use cases may warrant different samples or documentation.
• Remove Responsive Breakpoints. Design highly likely to change. Too much code is hinderence.
• Rename Item -> DummyItem
• Rename item folder -> dummy_feature
• Remove ItemController
• Add code comments throughout codebase
• Clean up pubspec.yaml
• Remove build methods, only use Widgets
• Finalize analysis options

[filiph]

When I checked out the PR just now and ran flutter pub get, I get an error:

/Users/filiph/fvm/versions/stable/bin/flutter --no-color pub get
Resource attribute "@appTitle" was not found. Please ensure that each resource has a corresponding @resource.
Generating synthetic localizations package has failed.
Process finished with exit code 1

Something with i18n? Just thought I'd mention it.

[brianegan]

Ah, interesting -- I haven't run into that error myself, but I've added a @appTitle key/value pair to the arb file just in case.

I'd guess we're running slightly different versions of Flutter :)

[filiph]

I still can't get this to work on stable. The i18n files won't generate. Switching to dev to see if that helps.

[brianegan]

Sorry about that, Filip! Totally my bad -- I'd committed the change and thought I'd pushed it before our meeting, but I mistakenly hadn't. Hopefully work now!

[brianegan]

Thanks again for the feedback, everyone! I'll merge this up and close it out. I've created an official proposal on the Flutter repo if you'd like to follow the conversation further :)

https://github.com/flutter/flutter/pull/76519