search

brianegan / new_flutter_template

Test ideas for a new flutter template
140 stars 23 forks source link

Should the template setup localizations? #4

Open brianegan opened 3 years ago

brianegan commented 3 years ago

Should the template include the necessary work to set up localizations? This includes adding an l10n.yaml, en.arb, modify the pubspec.yaml to generate localization, and use the AppLocalizations for Strings throughout the app.

This might be overkill for intermediate developers or it might be a healthy nudge in the right direction. What are your thoughts?

  1. No localizations
  2. Placeholder that links to more information
  3. Localize only the title of the app
  4. All strings localized

Background: https://flutter.dev/docs/development/accessibility-and-localization/internationalization

orestesgaolin commented 3 years ago

Yes, I'm in favor of new localization support by using basic localization delegate and translating all strings to English as default. It might be necessary to explain flutter.generate property in pubspec.yaml in more detail.

chimon2000 commented 3 years ago

Yes, I think localization by default is a great feature!

RobertBrunhage commented 3 years ago

I am a bit on the fence with this. Sure it's nice to have it on a project but this also adds more things a novice need to think about right of the bat. But I am very much in favor of adding some kind of documentation stating how and why you would implement it.

I may have missed it but looking at other starting projects from other frameworks, localizations is a typical thing that is not implemented in the beginning.

alestiago commented 3 years ago

Would appreciate it. Both 3 and 4 sound great to me.

mhadaily commented 3 years ago

Having a quick setup for localization is very nice, to have a better example I belive we should go for 4- All strings localized

burhanrashid52 commented 3 years ago

I would go with options 2. And also agrees with @RobertBrunhage comment of "adding more things". Developers who are building apps for countries that do not have English as their primary language will tend to have this feature to be included in the template. Setting up localization requires a lot of boilerplate code and very hard to understand at first glance. IMO for beginners, it will be too much to learn.