briangonzalez / jquery.pep.js

👟 Pep, a lightweight plugin for kinetic drag on mobile/desktop

http://pep.briangonzalez.org

1.3k stars 178 forks source link

Changed revert coordinates only when place is true. #163

Closed johnpmitsch closed 9 years ago

johnpmitsch commented 9 years ago

When place option is false, the MoveTo function moves the elements to an offset position. Revert now functions correctly when place is true or false.

Anaphase commented 9 years ago

Can we get this merged? I'm having the same problem as @inversiondk described here

@johnpmitsch change broke existing functionality, and presumable this change fixes is. Wondering why this was never merged but the breaking change was.

Anaphase commented 9 years ago

I just realized that the arguments are flipped in this pull request:

this.moveTo(this.initialPosition.top, this.initialPosition.left);

should really be

this.moveTo(this.initialPosition.left, this.initialPosition.top);

Anaphase commented 9 years ago

163 is a failed attempt to fix the problems caused by #162. #168 should be merged in place of #163 and #163 should be closed.

johnpmitsch commented 9 years ago

@Anaphase +1

Anaphase commented 9 years ago

Closed as per #168