briangormanly / 4dflib

4DF (Fourth Dimensional Form) Library
http://www.4dflib.com
GNU Lesser General Public License v3.0
5 stars 4 forks source link

Getting with History #30

Closed blackjack26 closed 8 years ago

blackjack26 commented 8 years ago

So I'm not sure if you are currently working on this or not, but when I call getUserByIdWithHistory it only returns the current user.

I have found the error in the code where the function setWithHistory() in FdfCommonServices calls addByDf() which then looks for "df <> true" but it should be looking for both true and false, or just not even have that in the SqlStatement where clause.

I suggest to make the setWithHistory() function like the following:

protected static void setWithHistory(long tenantId, WhereStatement whereStatement) {
         // REMOVE THIS
         // addByDf(whereStatement);

         addByTid(tenantId, whereStatement);
}