search

brianhie / geosketch

Geometry-preserving random sampling
http://geosketch.csail.mit.edu
MIT License
75 stars 11 forks source link

Update scikit-learn to v0.24 #10

Closed prete closed 3 years ago

prete commented 3 years ago

Main change: Updated scikit-learn dependency to v0.24.

In v0.24 sklearn.cluster.k_means_ was deprecated so it's been changed to sklearn.cluster._kmeans in kmeanspp.py. The idea behind that is that it would be useful for this package not to have an old dependency on scikit-learn<=0.22.

Additional minor fixes:

Disclaimer: didn't find any test to run on the package, so you may want to double check the new ouptus.

brianhie commented 3 years ago

Thanks so much for the PR @prete! I cloned your version and ran it, and it does look good to me. Thanks especially for the changes to the non-geosketch portions of the repo.