search

brianhorn / Tunerly

A minimalistic, multi-language pitch tuning app
GNU General Public License v3.0
44 stars 8 forks source link

Adding custom tuning #24

Open ilyss01 opened 2 years ago

ilyss01 commented 2 years ago

It would be nice if I could to add new custom tunings. Like FACGCE or DADAC#E or anything

ShrekhavingabadDay commented 2 years ago

Hi ilyss01!

I've been planning on adding some new tunings as well, it seems to be a little cumbersome at the moment, but it's definitely not too complicated: 1) you'll need to find all the frequencies to the desired notes in the given tuning. Here's an epic table to help 2) next you add an entry for the tuning in this file

all this only works, if you know some things about the inner workings of git(hub). If you don't, I'd gladly help, maybe by adding mine along with yours in one bigger pull request.

Hope you have a great day!

ilyss01 commented 2 years ago

Hi ShrekhavingabadDay,

The problem is that I am not competent enough in android dev and music theory to do any code change. I mean I know kotlin at some level but it's definitely not even remotely decent skill to write code. So sorry about that.

Thank you for your comment and external links btw

ShrekhavingabadDay commented 2 years ago

Adding an in-app tuning editor is something that needs a lot of thinking before implemented to make it user-friendly and non-confusing, so as long as that's not a feature I could add your tunings along with some of mine in a bigger PR if you let me know which ones you need specifically.