search

brianjp93 / lolsite

The source code for hardstuck.club -- a league of legends match history/stats site.
https://hardstuck.club
11 stars 4 forks source link

Champion stats only use the 10 visible games on the page #58

Closed JacobWillkomm closed 6 months ago

JacobWillkomm commented 6 months ago

Attached are two screenshots highlighting the issue.

I assume the source of the bug is that the queue filter and pagination happen, and then the stats are calculated; where as expected behavior might be: queue filter happens, stats are calculated, then pagination happens.

page1

pagw2

brianjp93 commented 6 months ago

not a bug. That's just how I wrote it to be

brianjp93 commented 6 months ago

Having overall stats would be nice too, but we have to import all of their games for that to work. Maybe that could be something to change.

brianjp93 commented 6 months ago

Gonna close this but maybe we can change how it works in the future.

JacobWillkomm commented 6 months ago

Ah right, I forget it doesn't do that already.

Option to increase the number of games per page?

brianjp93 commented 6 months ago

Sure, we could add a dropdown next to the next/prev page buttons with a dropdown with a selection for 1,20,50 games. Are you just throwing ideas out there or is that something you want to implement?

JacobWillkomm commented 6 months ago

A little of column A a little of column B. But I'll take a crack at implementing this one sometime this week.

On Mon, Mar 25, 2024, 12:15 Brian Perrett @.***> wrote:

Sure, we could add a dropdown next to the next/prev page buttons with a dropdown with a selection for 1,20,50 games. Are you just throwing ideas out there or is that something you want to implement?

— Reply to this email directly, view it on GitHub https://github.com/brianjp93/lolsite/issues/58#issuecomment-2018728412, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADF4O6T7WUFABW3JKQQCF4DY2BZU7AVCNFSM6AAAAABFE45DS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYG4ZDQNBRGI . You are receiving this because you authored the thread.Message ID: @.***>