search

briankabiro / react-native-get-sms-android

React Native module to get messages on an Android device
MIT License
137 stars 68 forks source link

Replace 0 by PendingIntent.FLAG_IMMUTABLE for Android>12 comptatibility #98

Open julien-ctx opened 12 months ago

julien-ctx commented 12 months ago

This pull request addresses the requirement of specifying either FLAG_IMMUTABLE or FLAG_MUTABLE when creating PendingIntent instances on Android 12 (API level 31) and higher, as per Android 12 behavior changes.

I edited the source code to replace 0 by FLAG_IMMUTABLE when creating new instances of PendingIntent. In our case, we don't need the PendingIntent to be mutable. That's why I used FLAG_IMMUTABLE.

Thanks to those changes, the library can be used again on latest versions of Android and we avoid having the following error when using the library's methods :

Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE

For more information: check the StackOverflow post explaining the issue and its fix.

rammos92 commented 11 months ago

can we add an id for autosend and callback?

navdeeshahuja commented 7 months ago

This should be merged. Facing same problem