Closed erikvold closed 12 years ago
erikvold
commented
12 years ago this guide explains a little about how to use 3rd party modules
protocol is here. I usually clone the repo to ~/github/ then ln -s ~/github/protocol protocol from the packages folder of my sdk clone.
brianking
commented
12 years ago Oh I see. So does that do a copy, and will 'cfx xpi' then bundle it?
Also, that will be flagged by the AMO validator I am sure as not being a core SDK file.
erikvold
commented
12 years ago yes and yes.
brianking
commented
12 years ago Thanks, works now.
This checkin has caused 1 regression. I have filed issue #18 for it.
brianking
commented
12 years ago Can about: pages have a favicon I wonder?
erikvold
commented
12 years ago I just tried adding a favicon with <link rel="icon" type="image/jpg" href="..."> and that worked.
brianking
commented
12 years ago Seems like protocol is broken in 1.8:
erikvold
commented
12 years ago hmm it looks like this lib is going to be part of the sdk https://github.com/mozilla/addon-sdk/pull/290
We may still need to work around the 1.8 issue tho..
I'll ask @gozala about it.
Gozala
commented
12 years ago If someone want's to send in pull request I'd be happy to accept. The problem is module wrapper here: https://github.com/Gozala/jetpack-protocol/blob/master/selfish.js#L6
protocol is not resolving:
$ cfx run Traceback (most recent call last): File "c:/mozilla/addon-sdk/addon-sdk-1.7/bin/cfx", line 33, in
cuddlefish.run()
File "c:\mozilla\addon-sdk\addon-sdk-1.7\python-lib\cuddlefishinit.py", l
ine 626, in run
deps = packaging.get_deps_for_targets(pkg_cfg, targets)
File "c:\mozilla\addon-sdk\addon-sdk-1.7\python-lib\cuddlefish\packaging.py",
line 275, in get_deps_for_targets
raise PackageNotFoundError(dep, required_reason)
cuddlefish.packaging.PackageNotFoundError: protocol (required by 'remo-companion
')
(addon-sdk-1.7)