Formatting and style changes.

[bearmannl]

The main function script (AutoSPInstallerFunctions.ps1) was changed to use VS Code (MS PowerShell extention) auto formatting to increase readability and maintainability of the script. This brings a lot of changes to the script in terms of additions and deletions, however the functions were not edited in any way other than style. Tested the script, should still perform 100% as before.

After the auto indentations from the first pass with VS Code a lot of function blocks broke because the { character came in behind some comment fields, 2nd pass corrected this to ensure the script now works as before.

Use of aliases removed to make the script more consistent overall and more robust out in the world.

[brianlala]

Wow that was brave of you, yes the functions file was admittedly a dog's breakfast in terms of formatting and style. I'll have a look and make sure it doesn't break anything as well.

Brian

[bearmannl]

Have you had a look? I've currently used the altered script at three clients and it works as intended. Hope you concur that it works as intended.

Mike

[brianlala]

Not yet - will do soon though. I've already started to incorporate VS Code style/formatting recommendations in some of my other stuff though, so far so good.

[McAndersDK]

please fix the Lookalike dash on line 4374 -SearchTopology New-SPEnterpriseSearchContentProcessingComponent –SearchTopology $clone -SearchServiceInstance $searchSvc | Out-Null to New-SPEnterpriseSearchContentProcessingComponent -SearchTopology $clone -SearchServiceInstance $searchSvc | Out-Null

Took me hours to find :)

[brianlala]

@McAndersDK yes looks like there were actually a few of them - can you please log this as a separate issues since it's different than the current request?

Cheers Brian

[bearmannl]

@brianlala I've also done some refactoring on the AutoSPInstallerMain.ps1 script and I've included the Em Dash fix as suggested by @McAndersDK I've tested the updated scripts on SP2013 & SP2016 installations, including most common services such as Search, MMS, etc.

Let me know if there's anything I can do to help with the testing effort.

Rgds, Mike

[brianlala]

Thanks for the hints and suggestions - I'm actually working on refactoring it too, as a module with a bunch of additional fixes as well.

[bearmannl]

Merging has become rather complex with the SharePoint 2019 refactor. May re-open a request at a later date.