search

brianleect / binance-pump-alerts

Tracks prices of pairs on binance and notifies when price movements based on pre-defined parameters are met.
142 stars 42 forks source link

[Feature Request] Making param names consistent #35

Closed patbaumgartner closed 3 years ago

patbaumgartner commented 3 years ago

In params.py the first params are written lower case whereas other params are written UPPER_CASE. I would love to adjust the Dockerfile for all params in the same way. Therefore it would be great to have all the params written in the same way. WDYT? Is there a specific reason?

Best, Patrick

brianleect commented 3 years ago

In params.py the first params are written lower case whereas other params are written UPPER_CASE. I would love to adjust the Dockerfile for all params in the same way. Therefore it would be great to have all the params written in the same way. WDYT? Is there a specific reason?

Best, Patrick

Ah the initial params were lowercase due to bad implementation on my part. Started changing to CAPS convention later on.

Yep we should change it all to CAPS.

patbaumgartner commented 3 years ago

Can we move it maybe into a property or even a yaml file? Since it is configuration?

brianleect commented 3 years ago

Can we move it maybe into a property or even a yaml file? Since it is configuration?

We could move it. However, I'm not familiar with the setting up the property / yaml file.

brianleect commented 3 years ago

Alternatively we could just rename the current non-cap parameters to CAPs.

patbaumgartner commented 3 years ago

I could create a pull-request and playing a bit with it. Want me to make a suggestion?

On Fri, Aug 6, 2021 at 11:01 PM Brian Lee Cheow Teng < @.***> wrote:

Alternatively we could just rename the current non-cap parameters to CAPs.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/brianleect/binance-pump-alerts/issues/35#issuecomment-894516024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADDJ7GEX4RN6KIPHQW4EH3T3RETNANCNFSM5BWQWMRA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .