search

brianleect / binance-pump-alerts

Tracks prices of pairs on binance and notifies when price movements based on pre-defined parameters are met.
142 stars 42 forks source link

[Bug] Delay fix, round down hour #70

Closed brianleect closed 2 years ago

brianleect commented 2 years ago

Closes #66

Original suggestion was to restart at fixed intervals but it would lead to missing gaps of data that would not be easily resolved without additional complexity.

After some thought, considering delay due to message sending over time will always result in a message being sent later, a simple fix would just to constantly round down to the nearest hour while setting time for last trigger.

Will run this version and see if it resolves the TDPA delays before sending.

brianleect commented 2 years ago

image

Seems to be functioning as intended. Will give it another day and then merge if everything is good.

velajos commented 1 year ago

Hi @brianleect , I left you a message in the original post but it's closed. If you have the opportunity to review it, I appreciate it. Cheers