search

brianleect / etherscan-labels

Full label data dump of top EVM chains in JSON/CSV.
MIT License
249 stars 73 forks source link

[QOL] Rework label ignore list to be flexible instead of hardcoded #15

Open brianleect opened 1 year ago

brianleect commented 1 year ago

Problem: Existing label ignore list is hardcoded to skip manually reviewed large number labels we deem unnecessary.

When new labels are added it requires users to manually add label name to hardcoded ignore list or spend a lot of time scraping an irrelevant label which may add unnecessary friction to usage

Soln: A better implementation would be to

  1. User defined value IGNORE_IF_EXCEED requested at runtime or config
  2. Extraction of token and account value for label during label cloud reading
  3. If it value from 2. exceed IGNORE_IF_EXCEED skip label
brianleect commented 1 year ago

Very weird that I'm unable to get the text from the element. If anyone can fix this it'll be a great QOL addition lol