brianleect / etherscan-labels

Full label data dump of top EVM chains in JSON/CSV.
MIT License
263 stars 78 forks source link

[Bug] No Matching Records found #7

Closed brianleect closed 2 years ago

brianleect commented 2 years ago

Missing some data

https://etherscan.io/accounts/label/genesis https://github.com/brianleect/etherscan-labels/blob/main/data/genesis.json image

brianleect commented 2 years ago

image

Seems that 27 labels are impacted.

Occurred due to previous assumption of sub-cat-id =0 not holding true always.

https://etherscan.io/accounts/label/augmented-finance?subcatid=1&size=25&start=25&col=1&order=asc

brianleect commented 2 years ago

Pretty weird that completely no record is found for the subcatid=0 even though https://etherscan.io/accounts/label/augmented-finance?subcatid=0&size=100&start=0&col=1&order=asc

Has 1 entry but is not visible at all?

image

brianleect commented 2 years ago

Weird potential fix is using subcatid=undefined seems to choose the page with relevant entries.

Setting to subcatid=0 sets to "Others" with 1 entry that isn't captured for some reason. https://etherscan.io/accounts/label/genesis?subcatid=0&size=100&start=0&col=1&order=asc

Setting to subcatid=undefined sets to "Main" which has 12 entries of interest https://etherscan.io/accounts/label/genesis?subcatid=undefined&size=100&start=0&col=1&order=asc

Pretty hacky fix but seems to work.

brianleect commented 2 years ago

Fixed but have error with

https://etherscan.io/accounts/label/take-action

https://etherscan.io/accounts/label/take-action?subcatid=undefined&size=100&start=0

Not sure why it loads properly while manually accessing but has error elsewhere.

image

Looking at logs, seems that we extracted till index 2800 before the error occurred. Might be a rate limit problem?

brianleect commented 2 years ago

On second run, retrieved take-action successfully.

No problem seems to occur for most cases and in the case where it crashes we can simply restart from last failed point so its not a huge deal.