Website issues

[ljacqu]

Great to see the site back up again—I'd like to report a few issues I've noticed while browsing the site.

• The first entry on https://wtfjs.com/, "2016 03 19 wierd instanceof", leads to a page that just says "wtf! not found"

• You're not setting the charset to UTF-8. E.g. https://wtfjs.com/wtfs/2014-02-20-math-pow shows "— @123jimin" instead of "— @123jimin" in my browser

• https://wtfjs.com/wtfs/2013-12-15-charAt-is-not-the-same-as-[] is just an empty page

• https://wtfjs.com/wtfs/2010-04-31-isNaN links to https://wtfjs.com/2010/02/12/null-is-not-an-object which just shows {"message":"Missing Authentication Token"} The link should be https://wtfjs.com/wtfs/2010-02-12-null-is-not-an-object

• https://wtfjs.com/wtfs/2015-04-23-screwy-negative-array-index is missing newlines

[DTrejo]

blerg :/

@ljacqu would you be open to helping with a pull request to fix these? I'm not asking you to make one right now, I'm just curious if you'd be open to helping.

[ljacqu]

Absolutely! Some of them I don't think I can help, but I can definitely contribute some. I'll open a pull request tomorrow.

[DTrejo]

wahoo! :)

On Sat, Aug 5, 2017 at 2:17 PM, ljacqu notifications@github.com wrote:

Absolutely! Some of them I don't think I can help, but I can definitely contribute some. I'll open a pull request tomorrow.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brianleroux/wtfjs/issues/147#issuecomment-320470940, or mute the thread https://github.com/notifications/unsubscribe-auth/AADbNy0j9dQi-k1Ed7ifqdkfcqYewn8tks5sVNvdgaJpZM4Ouda4 .

[ljacqu]

I won't be able to submit a PR today but I've started doing some copy-editing. At a later time I'll get the website running locally and I'll try to take care of more technical stuff, such as the encoding issue. Cheers :)

[DTrejo]

Sounds good - go easy on yourself :)

On Aug 6, 2017 6:04 AM, "ljacqu" notifications@github.com wrote:

I won't be able to submit a PR today but I've started doing some copy-editing. At a later time I'll get the website running locally and I'll try to take care of more technical stuff, such as the encoding issue. Cheers :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brianleroux/wtfjs/issues/147#issuecomment-320505781, or mute the thread https://github.com/notifications/unsubscribe-auth/AADbN3iUUCBzxRMXV65T_4FT3YMmSbVVks5sVbn1gaJpZM4Ouda4 .

[ljacqu]

Thanks! A pull request will follow on Sunday that will address the points in the issue description ;3 Edit: https://wtfjs.com/wtfs/2010-04-16-build-your-own-wtfjs is this still up-to-date to run the website locally?

[DTrejo]

Cool :) even if you only fix one, still send the PR!

On Aug 10, 2017 2:03 AM, "ljacqu" notifications@github.com wrote:

Thanks! A pull request will follow on Sunday that will address the points in the issue description ;3

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brianleroux/wtfjs/issues/147#issuecomment-321494620, or mute the thread https://github.com/notifications/unsubscribe-auth/AADbN446g0xVogA0DJUQmc75P8hUhrReks5sWsdNgaJpZM4Ouda4 .

[shaedrich]

Looks like everythink except your third bullet point have been addressed in the now merged PR. Furtunately, this has been addressed in #160