search

brianleroux / xui

A tiny javascript framework for mobile web apps.
http://github.com/xui/xui
391 stars 159 forks source link

No xui.events. Commit efd813bbfa6ff2ccafa92c9b289d173193560ca8 breaks xui. #34

Closed zdennis closed 13 years ago

zdennis commented 13 years ago

The following commit efd813bbfa6ff2ccafa92c9b289d173193560ca8 breaks xui. It assumes xui.event is an object, but it is never assigned. Putting the following in our code fixes this:

xui.events = {};

Any ideas for long-term fix?

remy commented 13 years ago

Sorry - that's my changes. Yep - adding xui.events = {} fixes it. I'm working on bespoke events, i.e. akin to jQuery special events - not particularly better, just simplified.

filmaj commented 13 years ago

+1, also commenting out line 63 of core/event.js fixes this.

remy commented 13 years ago

Fixed - sorry!