search

brianlmoon / net_gearman

A PHP interface for Gearman
84 stars 46 forks source link

Silent return type notices under PHP 8.1 #53

Closed dynamicnet closed 8 months ago

dynamicnet commented 1 year ago

Ok, there is only 2 notices, so it was done quickly adding the #[\ReturnTypeWillChange] attribute

ziemkowski commented 1 year ago

@brianlmoon this would be greatly appreciated until such time that you make a v3 (with types?) requiring php >= 8

badraxas commented 8 months ago

@brianlmoon Could you consider merging this tiny request to avoid deprecation notices in PHP 8.1 and later?

brianlmoon commented 8 months ago

Yes, I plan to do a larger, more invasive update for PHP 8.1+ soon. It will probably be a new project name and all to avoid confusion.