brianloveswords / base64url

For encoding and decoding base64url!
MIT License
224 stars 44 forks source link

Buffer created without "new" #15

Closed fabiancook closed 7 years ago

fabiancook commented 7 years ago

L29 of index.js contains var buffer = Buffer(paddedStringLength);, where it should be var buffer = new Buffer(paddedStringLength);

Doing so will give the warning (node:25634) DeprecationWarning: Using Buffer withoutnewwill soon stop working. Usenew Buffer(), or preferablyBuffer.from(),Buffer.allocUnsafe()orBuffer.alloc()instead. in node v7

fabiancook commented 7 years ago

Man I must be using a real old version, see all the updates have sorted it!