search

brianloveswords / base64url

For encoding and decoding base64url!
MIT License
224 stars 44 forks source link

Prevent declaration confliction to @types/node package #21

Closed JCloudYu closed 5 years ago

JCloudYu commented 7 years ago

Remove the customized version of node typings package to prevent confliction to global @types/node package

I recently having a duplicated declaration issue when interacting this module in typescript environment. It turns out that the node package carried by this module conflicts with the global @types/node package dependent by other modules. So I remove the typings and add dependency to the global one.

jacobwgillespie commented 6 years ago

@brianloveswords would it be possible to get this merged? base64url is a very popular package, but due to the fact that it includes the Node TypeScript definitions inside its package, it breaks the builds for anyone using TypeScript and this package or any package that depends on this package.

As you can imagine, that's a lot of packages.

This PR fixes the issue and properly moves the @types/node to a dev dependency. It would make a large part of the npm ecosystem much nicer if it was merged.

MylesBorins commented 5 years ago

This ended up being fixed in https://github.com/brianloveswords/base64url/commit/5a65f0642d0166a61f0fada8d556152a14ae19b3

Thanks for submitting!!!