brianloveswords / buffer-crc32

A pure javascript CRC32 algorithm that plays nice with binary data
MIT License
97 stars 30 forks source link

Deprecated Buffer API #20

Closed kibertoad closed 10 months ago

kibertoad commented 10 months ago

This library uses new Buffer, which is deprecated. Buffer.allocUnsafe should be used instead

Would you be open to a PR fixing this?

brianloveswords commented 10 months ago

I'd be open to that PR!

kibertoad commented 10 months ago

@brianloveswords Thank you! Since Travis CI stopped working long time ago (and is no longer a good option for OSS), I've opened a PR to add GitHub Actions CI, to ensure that changes won't break anything: https://github.com/brianloveswords/buffer-crc32/pull/21

kibertoad commented 10 months ago

@brianloveswords I only now realised that you actually have a check in your code already that only uses old API for old Node versions. Do you still intend to support all of Node versions, or you are open to releasing a new semver major dropping support for anything below Node 8?

brianloveswords commented 10 months ago

@kibertoad I'm open to a major bump that drops old versions

brianloveswords commented 10 months ago

fixed by #27