search

brianloveswords / streamsql

A streaming, backend agnostic SQL ORM heavily inspired by levelup
MIT License
67 stars 7 forks source link

Adding `where` clause to joined queries #2

Closed andrewhayward closed 10 years ago

andrewhayward commented 10 years ago

Including relationships in a get is ignoring the query, seemingly because you're not adding whereSql in the withJoin sub-function.

brianloveswords commented 10 years ago

AH, my bad. Any chance of including a test? If not I can throw one in. Thanks!

andrewhayward commented 10 years ago

Yep, that can be done.

andrewhayward commented 10 years ago

I've not touched the sqlite test file - will happily add tests for that too, but there are several tests already there that are commented out, including one for relationships, so not sure what state that's in.

brianloveswords commented 10 years ago

Rad, yeah, I can handle the sqlite file. Thanks!!

brianloveswords commented 10 years ago

Added you to AUTHORS file, published 0.4.1