search

brianloveswords / zlib-browserify

browserifyable zlib implementation for JavaScript
MIT License
31 stars 11 forks source link

update zlib dependency to 0.1.7 #8

Closed andrewrk closed 11 years ago

andrewrk commented 11 years ago

also removed dead dependency from package.json

brianloveswords commented 11 years ago

Sorry for the long delay on this! GitHub didn't have me as "watching" the repo for some reason so I wasn't getting any notifications for it.

This is actually the opposite of what I want: I want to be using tape and not tap for testing. So tap should be removed and the test script should be changed to use tape. They are functionally identical on the command line, but tape also works in the browser so it can be used with testling

andrewrk commented 11 years ago

Cool do you want to pull the request anyway since it does not change testing behavior at all and updates the zlib dependency? You can always fix your testing setup the way you want later.

brianloveswords commented 11 years ago

AH HA, I didn't notice the supressed diff – at first glance it seemed like just a package.json change.

The easiest thing would be if you committed another request to reverse the package.json change (github will automatically update this PR if your push it to you master branch). If you don't wanna do that, I can merge this and then make the change myself.

andrewrk commented 11 years ago

how's that?

brianloveswords commented 11 years ago

Awesome, thank you!! :pizza:

andrewrk commented 11 years ago

oh and please make sure to remove tape from dependencies. (put it in devDependencies) nobody wants the "tape" code running in their browser in production

brianloveswords commented 11 years ago

v0.0.3 published on npm