Make it possible to override -std=c++11 flag

brianmario / charlock_holmes

Character encoding detection, brought to you by ICU

MIT License

1.03k stars 140 forks source link

Make it possible to override -std=c++11 flag #153

Closed stanhu closed 4 years ago

stanhu commented 4 years ago

On CentOS v6, which ships with g++ v4.4.7, the -std=c++11 flag doesn't work but -std=c++0x does. This change makes it possible to install charlock_holmes via:

gem install charlock_holmes -- --with-cxxflags=-std=c++0x

Closes #152

stanhu commented 4 years ago

@tenderlove What do you think about this change?

tenderlove commented 4 years ago

@stanhu it makes sense. I'll merge.

rnestler commented 1 month ago

Will this be included in the next release? The build also breaks on newer systems which would need to pass the -std=c++17 flag. See https://github.com/brianmario/charlock_holmes/issues/173 for example.