search

brianmario / charlock_holmes

Character encoding detection, brought to you by ICU
MIT License
1.04k stars 141 forks source link

Remove -std=c++11 in CXXFLAGS #174

Closed rnestler closed 3 months ago

rnestler commented 4 months ago

The default mode on a system should be fine in most cases. If a user needs to declare a special -std they can easily do it themselves by passing --with-cxxflags=-std=c++11.

Fixes https://github.com/brianmario/charlock_holmes/issues/173

stanhu commented 2 months ago

@tenderlove This actually broke compiling the extension for macOS: #177. https://github.com/brianmario/charlock_holmes/pull/179 seems to solve the issue for me. Probably worth adding macOS to CI.

tenderlove commented 2 months ago

@stanhu ugh. Thanks for sending the PR. I'll add macOS to CI too. Thank you!

rnestler commented 2 months ago

@stanhu @tenderlove Sorry for breaking it for macOS :see_no_evil: But running gem install charlock_holmes -- --with-cxxflags=-std=c++11 should work, right?

tenderlove commented 2 months ago

@rnestler don't worry about it, we didn't have CI before (but we do now). Also yes, it should work fine if you pass the cxxflags manually. 😄