search

brianmario / mysql2

A modern, simple and very fast Mysql library for Ruby - binding to libmysql
http://github.com/brianmario/mysql2
MIT License
2.25k stars 550 forks source link

mysql2 gem crashes randomly #1019

Open herbertia opened 5 years ago

herbertia commented 5 years ago

I am in the process to upgrade our application to Rails 5. I have upgraded to ruby 2.4.5 with all the gems in our gemfile with Rails 5.2.2. The mysql2 gem is 0.5.2. When I am running our tests and I have randoms errors:

Each time I am running the same tests I have either a crash or a seg fault and the mysql errors. It never happens at the same place or in the same tests. The same tests are running perfectly on Ruby 2.2.9, Rails 4.2.8 with mysql2 0.4.10. It has been several days that I am trying to google the issue without success. The versions are not that recent and I don't see reported issues.

I tried to uninstall mysql2, then re-install it. I have mysql 5.7 installed on my mac. I am on Mac OS 10.14.2.

Please advise

sodabrew commented 5 years ago

Since you have this failure during unit tests, can you try isolating the test(s) that cause the crash?

herbertia commented 5 years ago

I am going to try to isolate the tests but as it is random I'll see if I can reproduce it on a project

sodabrew commented 5 years ago

Any luck isolating this issue in your test suite?

herbertia commented 5 years ago

Yes I got the root cause of the problem. The mysql2 gem is crashing when doing the tests and in your model you have in a callback a job launched. Even if you don't test the job as the after callbacks are now fired in test it makes the gem to crash. I don't know if there is a solution to have an error message instead of a crash...

sodabrew commented 5 years ago

Can you post a minimal reproduction case?

herbertia commented 5 years ago

Yes I am going to try to do it this week.

azul commented 5 years ago

I'm seeing the same issue - the empty Mysql2::Error in 'affected_rows'). It also happens in a delete_all statement.

It's in an integration test though. So it may be a bit harder to isolate. I thought it was related to rails threat handling because it started showing up after i started using transactional fixtures in capybara integration tests again. This is with mariadb 10.1.38 runnig in docker. Rails 5.2.3, mysql2 0.5.2

I do not see any errors in the mysql error log or mysql general log.

I have not been able to reproduce this in a unit test. @herbertia , is this happening in a unit or an integration test for you?

DJ-MacHack commented 4 years ago

I have some similar issues but only on MySQL server version 8.0.17 (Community Server - GPL):

size:

  [1m[35m (0.5ms)[0m  [1m[34mSELECT COUNT(*) FROM `exports` WHERE `exports`.`date` = '2020-02-11'[0m

  ↳ config/initializers/scheduler.rb:21

--------------------------------------------------------------------------------

Mysql2::Error::ConnectionError: Wrong or unknown protocol: SELECT COUNT(*) FROM `exports` WHERE `exports`.`date` = '2020-02-11'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/mysql2-0.5.3-x64-mingw32/lib/mysql2/client.rb:131:in `_query'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/mysql2-0.5.3-x64-mingw32/lib/mysql2/client.rb:131:in `block in query'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/mysql2-0.5.3-x64-mingw32/lib/mysql2/client.rb:130:in `handle_interrupt'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/mysql2-0.5.3-x64-mingw32/lib/mysql2/client.rb:130:in `query'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/abstract_mysql_adapter.rb:187:in `block (2 levels) in execute'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activesupport-5.2.4.1/lib/active_support/dependencies/interlock.rb:48:in `block in permit_concurrent_loads'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activesupport-5.2.4.1/lib/active_support/concurrency/share_lock.rb:187:in `yield_shares'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activesupport-5.2.4.1/lib/active_support/dependencies/interlock.rb:47:in `permit_concurrent_loads'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/abstract_mysql_adapter.rb:186:in `block in execute'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/abstract_adapter.rb:581:in `block (2 levels) in log'

D:/RubyonRails/Ruby24-x64/lib/ruby/2.4.0/monitor.rb:214:in `mon_synchronize'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/abstract_adapter.rb:580:in `block in log'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activesupport-5.2.4.1/lib/active_support/notifications/instrumenter.rb:23:in `instrument'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/abstract_adapter.rb:571:in `log'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/abstract_mysql_adapter.rb:185:in `execute'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/mysql/database_statements.rb:28:in `execute'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/abstract_mysql_adapter.rb:196:in `execute_and_free'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/mysql/database_statements.rb:33:in `exec_query'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/abstract/database_statements.rb:478:in `select'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/abstract/database_statements.rb:70:in `select_all'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/abstract/query_cache.rb:106:in `select_all'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/connection_adapters/mysql/database_statements.rb:12:in `select_all'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/relation/calculations.rb:286:in `block in execute_simple_calculation'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/relation.rb:584:in `skip_query_cache_if_necessary'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/relation/calculations.rb:286:in `execute_simple_calculation'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/relation/calculations.rb:238:in `perform_calculation'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/relation/calculations.rb:146:in `calculate'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/relation/calculations.rb:52:in `count'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/activerecord-5.2.4.1/lib/active_record/relation.rb:211:in `size'

D:/RubyonRails/Projekt/config/initializers/scheduler.rb:21:in `block in <top (required)>'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/rufus-scheduler-3.6.0/lib/rufus/scheduler/jobs.rb:223:in `do_call'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/rufus-scheduler-3.6.0/lib/rufus/scheduler/jobs.rb:267:in `trigger_now'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/rufus-scheduler-3.6.0/lib/rufus/scheduler/jobs.rb:312:in `block (3 levels) in start_work_thread'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/rufus-scheduler-3.6.0/lib/rufus/scheduler/jobs.rb:315:in `block (2 levels) in start_work_thread'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/rufus-scheduler-3.6.0/lib/rufus/scheduler/jobs.rb:301:in `loop'

D:/RubyonRails/Ruby24-x64/lib/ruby/gems/2.4.0/gems/rufus-scheduler-3.6.0/lib/rufus/scheduler/jobs.rb:301:in `block in start_work_thread'

--------------------------------------------------------------------------------

in a task that is doing the same things again and againg every 10 minutes. When I start my application it works but only in the first run. In the second run it crashes. On another server with MySQL 8.0.16 (Community Server - GPL) the same DB and code it works well. Any idea why?

EDIT: I updatet both to 8.0.19 and have the same behaviour. On one machine it works like intended - on the other it runs 1 time and crashes in the second.