Specified flags are not compatible with Solaris Studio C compiler.

brianmario / yajl-ruby

A streaming JSON parsing and encoding library for Ruby (C bindings to yajl)

http://rdoc.info/projects/brianmario/yajl-ruby

MIT License

1.48k stars 169 forks source link

Specified flags are not compatible with Solaris Studio C compiler. #149

Open orderthruchaos opened 10 years ago

orderthruchaos commented 10 years ago

When using the Solaris Studio C compiler, the specified flags generate errors. This may affect other compilers, but this is at least a starting point.

lamont-granquist commented 10 years ago

This problem also affects AIX and the xlc compiler.

orderthruchaos commented 10 years ago

With @lamont-granquist's comment in mind, you may want to remove the condition on RbConfig::CONFIG['host_os'].

lamont-granquist commented 10 years ago

I'd suggest just using if RbConfig::MAKEFILE_CONFIG['CC'] =~ /gcc|clang/ to protect the gcc-specific flags.