Closed eileencodes closed 3 years ago
We don't want to merge this yet, as we first need to get Rails green.
Wow this is old, sorry about that!
Is this still of interest to you to get shipped?
Actually we should probably close this. I think we kind of determined that replacing json in Rails with Yajl was going to be too hard due to some monkey patching Rails does. This was a PR where we kind of attempted to fix it https://github.com/rails/rails/pull/34578. @tenderlove if you want to revive this let me know and I'll reopn.
Support as_json so we can change Rails' json implementation and this method is required. Yajl used to not support as_json because there was an infinite loop, but here if the object returns from as_json is not the one that we called as_json on then we dump that.
cc/ @tenderlove @brianmario