Performance demo on jsbin no longer works

brianmhunt / knockout-fast-foreach

Foreach. Faster. For Knockout.

MIT License

59 stars 18 forks source link

Performance demo on jsbin no longer works #14

Closed 4ver closed 9 years ago

4ver commented 9 years ago

I'm getting the same error with the latest version. If I revert to https://github.com/brianmhunt/knockout-fast-foreach/commit/ce7a29ee9896f6a2a148a9fe9f5dbe955c8d9766 it's okay.

knockout-min.js:63 Uncaught TypeError: Unable to process binding "fastForEach: function (){return {data:list,afterQueueFlush:afterQueueFlush} }"
Message: undefined is not a function

http://jsbin.com/heteca/6

Cheers.

brianmhunt commented 9 years ago

Thanks @4ver – the problem is #13, namely that I have not yet copied over some private KO functionality for virtualElements to this project. It'll still work with knockout-debug until I get a chance to fix it.

I've updated the links to a version of the JSBin that uses the -debug version, so will close this. But please let me know / reopen if I've missed the issue here. :)

Cheers

4ver commented 9 years ago

Thanks, everything works perfectly now.