search

brianmiller / phvalheim-server

PhValheim backend server
GNU General Public License v2.0
29 stars 5 forks source link

Make the servers with no citizens available in the public authorized page #54

Closed Swesen closed 6 months ago

Swesen commented 6 months ago

As the edit citizen page states that anyone should be able to join if left empty, one would expect the public authorized page to show these worlds.

resolves #5 resolves #26

brianmiller commented 6 months ago

Thank you for the merge request. Your change doesn't seem to work with NULL values. Selecting by NULL also doesn't seem to work. If I manually add a blank value to an existing world, then the select "" query works.

Maybe we need to adjust the language on the citizens page and simply add a public checkbox.

Swesen commented 6 months ago

Ok, so citizens start out as NULL and if you edit the citizens it turns into an empty string because that is what my server has. Having a seperate bool for making a world public would make it so you have to set this to empty/NULL and set it public, or would setting it public bypass the permittedlist.txt?

brianmiller commented 6 months ago

Setting the world to public would make the world visible to everyone and wipe the permit list on start.

brianmiller commented 6 months ago

I'm almost done with the changes. I should have an RC tag ready in 20-30 minutes.

brianmiller commented 6 months ago

2.19 rc is building now

brianmiller commented 6 months ago

nice work--I didn't realize we were both working on the changes :)

brianmiller commented 6 months ago

I've validated 2.19 and the latest tag has been pushed. We should have full public capability now.

brianmiller commented 6 months ago

@Swesen consider joining our Discord https://discord.gg/8RMMrJVQgy

It looks like you're more than capable of contributing to the project. 👍