search

briano1905 / typings

typings.gg is a sleek and modern typing test website. it support many custom themes
https://typings.gg
GNU General Public License v3.0
763 stars 139 forks source link

Question about XHR vs fetch() #23

Closed fr3fou closed 5 years ago

fr3fou commented 5 years ago

hiya!

I noticed that in some places of the code, such as

https://github.com/briano1905/typings/blob/ccadb7420d8ed1ac07ff5c41ba547d2b648d3a9b/main.js#L254-L266

you use an XMLHttpRequest, whereas in other places, such as

https://github.com/briano1905/typings/blob/ccadb7420d8ed1ac07ff5c41ba547d2b648d3a9b/main.js#L268-L282

you use fetch. Any reason why? If you'd like I could quickly fix it up and make them both use fetch :>

briano1905 commented 5 years ago

There are absolutely no reason for that. I'm just being inconsistent for no reason. And you can change it to fetch if you'd like

fr3fou commented 5 years ago

Fixed in #24