search

briano1905 / typings

typings.gg is a sleek and modern typing test website. it support many custom themes
https://typings.gg
GNU General Public License v3.0
763 stars 139 forks source link

Improve accessibility of theme menu #34

Closed jakergrossman closed 5 years ago

jakergrossman commented 5 years ago

Fixes issue #33

jakergrossman commented 5 years ago

Actually, it now highlights the themes button but pressing enter does nothing. I don't know the best way to solve that at the immediate moment.

Miodec commented 5 years ago

The problem here is that the themes button is just a div with an onclick function attached

Miodec commented 5 years ago

You could try and add an 'enter' event listener and if document.activeElement === the themes button then open the themes window.

But then, if you want to make the themes window accessible by tabbing, then you might aswell also make the whole themese window work with it aswell.

Im honestly not sure if its worth it, when its just so much easier to pick a theme using the mouse.

jakergrossman commented 5 years ago

You could try and add an 'enter' event listener and if ...

@Miodec of course, but having everything accessible via tab is good for accessibility on the site. If someone wasn’t able to use a mouse, they might be out of luck.