brianpipa / overreader-issues

A place to keep track of issues and TODOs for http://overreader.com
http://overreader.com
1 stars 0 forks source link

Increase maximum book count beyond 100 #10

Closed brianpipa closed 1 year ago

brianpipa commented 1 year ago

Right now the limit is 100 thanks to the RSS feed. Look into increasing this to some sane but usable limit. May want to get the mutithreading in place first

brianpipa commented 1 year ago

v1.6 -made the limit configurable - deployed it with a 400 limit

collinbarrett commented 1 year ago

It seems the RSS feed from Goodreads only shows up to 100 books. Based on your last comment, did you find a way to paginate the RSS feed so that you can search up to 400? Can you share how you are paginating the Goodreads RSS feed?

If the limit isn't dictated by Goodreads (100) but rather by Overreader (currently 400), I'd love an option to go even higher, as my to-read shelf currently sits at ~600. I'd be willing to pay a bit for that feature.

I tried to find a workaround by breaking my to-read shelf into two, but I couldn't find an easy-ish way to accomplish that.

brianpipa commented 1 year ago

@collinbarrett Sorry for the delay in answering. I just saw this. Yes. By default it serves up 100 but it supports pagination so I just changed my code to read each page like: return String.format("https://www.goodreads.com/review/list_rss/%s?shelf=%s&page=%s&per_page=%s", userId, shelf, pageNumber, RSS_PER_PAGE);

I arbitrarily limited it to 400. No real reason other than it takes a while to process that many. I created an Amazon Lambda to process the books (once I have the full list from GR) though and that does make it much faster. I just need to deploy it.

And yeah - managing large lists in GR isn't easy. There IS a way to do it that isn't too bad - i wanted to do the same at one point and found it in GR. it's called batch edit in GR.

collinbarrett commented 1 year ago

thanks! makes sense. I'mma hold out for awhile to see if you have the chance to / decide to raise the limit from 400. but, if my reading list dwindles, I'll look at batch edit to get my want-to-read under the limit.

thanks again for the fantastic app.

brianpipa commented 12 months ago

Send me your Goodreads userid and let me see what I can do. You can email it to me directly if you want.

collinbarrett commented 12 months ago

https://www.goodreads.com/review/list/137035410-collin-barrett?shelf=to-read

brianpipa commented 11 months ago

@collinbarrett Wow - 906 books. I'm working on some KU Browser improvements today but I'll see if I can hook you up tomorrow.

collinbarrett commented 11 months ago

Thanks! I'm sure I'll never read them all, but what is available via Libby from my library strongly nudges me as to which ones I read. Overreader makes it so much easier to find those!

collinbarrett commented 9 months ago

I was able to fairly easily create to-read-batch-x sub-lists with Goodreads' Batch Edit feature to copy my to-read list into <=400 lists for Overreader. That worked! https://www.goodreads.com/review/list/137035410-collin-barrett

Thanks again for the great tool!

brianpipa commented 6 months ago

@collinbarrett I just increased shelf size to 800