search

brianpkelley / md-color-picker

Angular-Material based color picker
MIT License
254 stars 120 forks source link

mdColorRgb = false still shows RBG tab in latest release on Bower #86

Open abdallahYashir opened 8 years ago

abdallahYashir commented 8 years ago

Hi,

Thank you for your angular color picker library. It looks amazing and works well. I only have an issue when I use the mdColorPicker.min.js from the bower installation.

The mdColorRGB still shows even when I add md-color-rgb="false" in the attributes or options config (mdColorRgb: false).

In contrast, when using the mdColorPicker.min.js in the dist folder cloned from git [1], it works well. Is there anything I am missing?

Thanks.

[1] https://github.com/brianpkelley/md-color-picker

LoganDupont commented 8 years ago

+1 Same for the md-color-hsl when you use the mdColorPicker.min.js from the bower installation but it seems that the latest version on github isn't the same as the latest version on bower. So would it be possible to create a new release for it?

zsee commented 8 years ago

I have the same issue, but it seems to be already fixed in the git repo. @brianpkelley I think you can close this issue, but I was just wondering when the next release be out?

pasket commented 7 years ago

I've checked my bower.json and I can see that I'm in the last version: "md-color-picker": "^0.2.6". However, md-color-rgb="false" and md-color-hsl="false" still are showing those tabs.

brianpkelley commented 7 years ago

I'm finally back to working on this project and am nearing a new release (or at least release candidate). Hopefully most of the open issues will be resolved in this. I pushed an extremely pre-alpha version last night, which uses the .config method to set, add, remove notations, tabs, etc. It will also support attribute options and a config object, but those haven't been added yet (they're next)