brianreavis / sifter.js

A library for textually searching arrays and hashes of objects by property (or multiple properties). Designed specifically for autocomplete.
1.09k stars 125 forks source link

TypeScript definitions #25

Open franklin-ross opened 9 years ago

franklin-ross commented 9 years ago

I use TypeScript pretty much everywhere these days and I often make my own definitions for libraries. I've made on for sifter and I'm wondering whether there's any interest in including it in the library? It would mean something else to update, but the API seems fairly small and stable.

I could probably manage to rustle up a PR if there's interest.

broerse commented 9 years ago

It is hard to know if there is any interest if people can't find sifter on TSD :smile:

franklin-ross commented 8 years ago

This is true. Personally I love it when I don't have to go to TSD as the definitions often seem to lag. There are also less steps involved when assessing a lib, since having the definitions is a pretty big win for anyone using TS, and it means you don't have go check that the ones on TSD are actually up to date.

On Thu, 23 Jul 2015 3:38 pm Martin Broerse notifications@github.com wrote:

It is hard to know if there is any interest if people can't find sifter on TSD http://definitelytyped.org/tsd/ [image: :smile:]

— Reply to this email directly or view it on GitHub https://github.com/brianreavis/sifter.js/issues/25#issuecomment-123978653 .