Change csv dependency to use an npm-available parser

brianreavis / sifter.js

A library for textually searching arrays and hashes of objects by property (or multiple properties). Designed specifically for autocomplete.

1.09k stars 125 forks source link

Change csv dependency to use an npm-available parser #45

Closed kiara-riley closed 7 years ago

kiara-riley commented 7 years ago

Hey @brianreavis,

We have had some issues lately with the way this csv dependency works. Especially behind proxies and what not. This just changes the dependency to use another parser that is accessible through npm.

I ran the tests, they were fine and I got the same results when running the csv commands you have in your README.md.

Let me know if I need to change anything here.

coveralls commented 7 years ago

Coverage remained the same at 93.434% when pulling 035f9ad0bec6a79d7b6f929a009bb22a9653060b on kraigmckernan:master into 59d61ce724ff7a0bf34ad08c0febcbc278dd9c78 on brianreavis:master.

brianreavis commented 7 years ago

Thanks Kraig – I think this'll make a lot of people happy. Looks great to me. Off topic: cool seeing other people in Bozeman on GitHub!

brianreavis commented 7 years ago

Released 0.5.2

kiara-riley commented 7 years ago

Thanks for the quick turnaround, our build is working again!

Yeah I was yelling out my window to see if you would fix it for us but you must not have heard me!

rliota commented 7 years ago

Thanks @kraigmckernan and @brianreavis!