briansemrau / godot_box2d

A C++ module that integrates the Box2D library with the Godot game engine by providing nodes for standard Box2D objects.
MIT License
45 stars 4 forks source link

Listen to Global Transform Change notifications #76

Open jasonwinterpixel opened 2 years ago

jasonwinterpixel commented 2 years ago

Use set_notify_transform() instead of set_notify_local_transform().

brianwinterpixel commented 2 years ago

You can merge this straight into winterpixelgames:winterpixel-main. LGTM

Side-note, I could have sworn there were situations where I wrote:

set_notify_local_transform(false);
// do something
set_notify_local_transform(true);

But I don't see them now. Curious.

jasonwinterpixel commented 2 years ago

You did it for kinematic bodies using set_notify_transform.

On Tue, Oct 18, 2022, 10:14 p.m. Brian Semrau @.***> wrote:

You can merge this straight into winterpixelgames:winterpixel-main. LGTM

Side-note, I could have sworn there were situations where I wrote:

set_notify_local_transform(false);// do somethingset_notify_local_transform(true);

But I don't see them now. Curious.

— Reply to this email directly, view it on GitHub https://github.com/briansemrau/godot_box2d/pull/76#issuecomment-1283399116, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS2HDAON3YFD2GYRVSGTI5TWD5YTHANCNFSM6AAAAAARIQRICY . You are receiving this because you authored the thread.Message ID: @.***>