briansmith / ring

Safe, fast, small crypto using Rust
Other
3.76k stars 708 forks source link

Add ECDSA_P384_SHA256_FIXED to ecdsa verification #1446

Open dodomorandi opened 2 years ago

dodomorandi commented 2 years ago

As commented in this issue, it should be pretty trivial to add support for ECDSA_P384_SHA256_FIXED.

Is there any particular reason the implementation is not already available? I just want to be sure that it is not been explicitly omitted for reasons.

briansmith commented 2 years ago

I was hoping to not have to add it. I think we only need it for specific legacy uses? I suggest:

dodomorandi commented 2 years ago

Ok, this is the kind of thing I wanted to hear. From your words, this algorithm is substantially deprecated and it should not be used, right? The issue I linked is related to the validation of Digital Green Pass, definitely not something that should use legacy/deprecated approaches. I don't have the knowledge to assess why it should not be used, but I feel that I can trust you. For my specific use-case, there is a good chance this specific algorithm should not have been used at all, therefore I feel more confident to refuse to validate the signed message than taking some security issues.

Tell me if this makes sense, and if you think that it is better to leave ECDSA_P384_SHA256_FIXED unimplemented (because, you know, _FOR_LEGACY_USE_ONLY won't stop people doing silly things), feel free to close the issue. Thank you for your time and your support!