search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.75k stars 704 forks source link

windows-sys 0.52 #1852

Closed kayabaNerve closed 9 months ago

kayabaNerve commented 11 months ago

I was unable to locally test this due to the asm/C code.

I also couldn't run the CI on this commit due to the amount of jobs the CI spawns.

I stripped the non-Windows CIs out on my master branch and the Windows CIs did pass, so I believe this is valid without any actual code edits.

See https://github.com/kayabaNerve/ring/actions/runs/7096652359 for those.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (317a062) 96.01% compared to head (12dbd18) 96.01%. Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1852 +/- ## ======================================= Coverage 96.01% 96.01% ======================================= Files 136 136 Lines 20692 20692 Branches 226 226 ======================================= Hits 19867 19867 Misses 791 791 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

briansmith commented 11 months ago

Thanks for the PR.

I was unable to locally test this due to the asm/C code.

No worries, because the CI will run the tests.

However, we shouldn't put "I was unable to locally test this due to the asm/C code" in the commit message because that isn't useful for people reading the history. Please amend the commit to explain why we are updating to 0.52.

kayabaNerve commented 11 months ago

Provided a more descriptive message.

briansmith commented 9 months ago

Thanks! I have tested this and merged it.