search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.74k stars 704 forks source link

Simplified `SystemRandom` with const constructor and `rand` (crate) API impl. #1868

Closed elfeiin closed 9 months ago

elfeiin commented 10 months ago

Quality of life PR to make rng easier to use. Anyone who understands rand can follow their examples to use SystemRandom.

Considered changes not done in this PR (yet)

Remove superfluous new constructor Add more docs Back ring::rand with crate rand under feature flag

If you merge I will be like this: :>

briansmith commented 9 months ago

I'm going to close this. In part, I doubt we'd add a new dependency on rand just to implement the rand traits. But also because these two changes would be better done as separate PRs if/when we do want to consider them.